From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param
Date: Thu, 17 Feb 2022 09:41:26 +0000 [thread overview]
Message-ID: <9c817a6f-ba41-1b68-5a7a-30032881057b@linux.intel.com> (raw)
In-Reply-To: <20220216181504.7155-1-vinay.belgaumkar@intel.com>
On 16/02/2022 18:15, Vinay Belgaumkar wrote:
> SLPC unset param H2G only needs one parameter - the id of the
> param.
>
> Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits")
How serious is this? Does it need backporting? If so:
Cc: <stable@vger.kernel.org> # v5.15+
?
Regards,
Tvrtko
> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index 13b27b8ff74e..ba21ace973da 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct intel_guc *guc, u8 id)
> {
> u32 request[] = {
> GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
> - SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
> + SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
> id,
> };
>
next prev parent reply other threads:[~2022-02-17 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 18:15 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param Vinay Belgaumkar
2022-02-17 9:41 ` Tvrtko Ursulin [this message]
2022-02-17 17:04 ` Belgaumkar, Vinay
2022-02-17 17:09 ` Tvrtko Ursulin
2022-02-17 11:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-02-17 19:12 ` [Intel-gfx] [PATCH] " Umesh Nerlige Ramappa
2022-02-17 20:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c817a6f-ba41-1b68-5a7a-30032881057b@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox