From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: avoid reading non-existent PLL reg on Ironlake+
Date: Thu, 30 Dec 2010 12:22:17 -0800 [thread overview]
Message-ID: <20101230122217.71576c0f@jbarnes-desktop> (raw)
In-Reply-To: <c6d829$q0l8db@fmsmga001.fm.intel.com>
On Thu, 30 Dec 2010 19:50:17 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, 30 Dec 2010 09:36:39 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > These functions need to be reworked for Ironlake and above, but until
> > then at least avoid reading non-existent registers.
>
> This looks good by itself and provided an opportunity for another tiny
> cleanup... Pushed to -next. Though it does raise the question if we are
> arming the upclock timer even when there is nothing to be done and so
> causing excess wakeups?
Yeah, we shouldn't be doing that. I thought we had it disabled but I
haven't checked.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-12-30 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 17:36 [PATCH 1/2] drm/i915: avoid reading non-existent PLL reg on Ironlake+ Jesse Barnes
2010-12-30 17:36 ` [PATCH 2/2] drm/i915: add pipe enable/disable functions Jesse Barnes
2010-12-30 18:00 ` Jesse Barnes
2010-12-30 19:50 ` [PATCH 1/2] drm/i915: avoid reading non-existent PLL reg on Ironlake+ Chris Wilson
2010-12-30 20:22 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101230122217.71576c0f@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox