Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Check that the plane points to the pipe's framebuffer before enabling
Date: Mon, 18 Apr 2011 08:54:44 -0700	[thread overview]
Message-ID: <20110418085444.2d020b6c@jbarnes-desktop> (raw)
In-Reply-To: <1303032761-2991-1-git-send-email-chris@chris-wilson.co.uk>

On Sun, 17 Apr 2011 10:32:41 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> Knut Petersen reported a GPU hang when he left x11perf running
> overnight. The error state quite clearly indicates that plane A was
> enabled without being fully setup:
> 
> PGTBL_ER: 0x00000010
>     Display A: Invalid GTT PTE
> Plane [0]:
>   CNTR: c1000000
>   STRIDE: 00000c80
>   SIZE: 03ff04ff
>   POS: 00000000
>   ADDR: 00000000
> 
> [That GTT offset on his system being pinned for the ringbuffer.]
> 
> This is a simple debugging patch to assert that this cannot be so!
> 

I like it (though now the comment talks about DSPADDR and leaves
DSPSURF out in the cold).

Sounds like our dpms code may be causing trouble for this x11perf run
perhaps?  What else would cause us to change base addrs during a bench
run like that?

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2011-04-18 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16 18:20 [PATCH] drm/i915: Check that the plane points to the pipe's framebuffer before enabling Chris Wilson
2011-04-17  9:32 ` Chris Wilson
2011-04-18 15:54   ` Jesse Barnes [this message]
2011-04-19  5:55     ` [PATCH] drm/i915: Check that the plane points to the pipes " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110418085444.2d020b6c@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox