From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Check that the plane points to the pipes framebuffer before enabling
Date: Tue, 19 Apr 2011 06:55:57 +0100 [thread overview]
Message-ID: <0d30dc$lta0jo@orsmga001.jf.intel.com> (raw)
In-Reply-To: <20110418085444.2d020b6c@jbarnes-desktop>
On Mon, 18 Apr 2011 08:54:44 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> I like it (though now the comment talks about DSPADDR and leaves
> DSPSURF out in the cold).
D'oh. That'll teach me to try and write a comment to explain a function
first!
> Sounds like our dpms code may be causing trouble for this x11perf run
> perhaps? What else would cause us to change base addrs during a bench
> run like that?
Right. The early observation is that we don't assign a framebuffer to
the CRTC borrowed for VGA/TV load detection. And I can postulate that we
contrived to access a PTE during a hotplug poll whilst rewriting the GTT
(or something similar to the object following the ringbuffer).
I think we can just attach the fbcon for the purposes of load detection.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-04-19 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 18:20 [PATCH] drm/i915: Check that the plane points to the pipe's framebuffer before enabling Chris Wilson
2011-04-17 9:32 ` Chris Wilson
2011-04-18 15:54 ` Jesse Barnes
2011-04-19 5:55 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$lta0jo@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox