From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Adam Jackson <ajax@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC PATCH] drm/i915/dp: Dither down to 6bpc if it makes the mode fit
Date: Fri, 22 Jul 2011 11:57:13 -0700 [thread overview]
Message-ID: <20110722115713.4aeee200@jbarnes-desktop> (raw)
In-Reply-To: <1311174531-23070-1-git-send-email-ajax@redhat.com>
On Wed, 20 Jul 2011 11:08:51 -0400
Adam Jackson <ajax@redhat.com> wrote:
> Some active adaptors (VGA usually) only have two lanes at 2.7GHz.
> That's a maximum pixel clock of 144MHz at 8bpc, but 192MHz at 6bpc.
>
> Signed-off-by: Adam Jackson <ajax@redhat.com>
> ---
>
> Patch is against drm-intel-next. Not even compile-tested yet, just
> looking for feedback. I _think_ the pre-gen5 path is right, the GM45 doc
> makes it sound like the bpc and dither bits only affect DP.
Yeah, it would be good to have this.
> + /* default to 8bpc */
> + pipeconf &= ~(PIPECONF_BPP_MASK | PIPECONF_DITHER_EN);
> + if (is_dp) {
> + if (mode->private_flags & INTEL_MODE_DP_FORCE_6BPC) {
> + pipeconf |= PIPECONF_BPP_6 |
> + PIPECONF_DITHER_EN |
> + PIPECONF_DITHER_TYPE_ST1;
> + }
> + }
> +
> dpll |= DPLL_VCO_ENABLE;
Maybe this part would be cleaner if you added G4x support to
choose_pipe_bpp_dither and called it here instead?
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2011-07-22 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 15:08 [RFC PATCH] drm/i915/dp: Dither down to 6bpc if it makes the mode fit Adam Jackson
2011-07-22 18:57 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722115713.4aeee200@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox