Re: [PATCH 1/2] drm/i915: re-enable semaphores by default

From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Eugeni Dodonov <eugeni.dodonov@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
Date: Mon, 14 Nov 2011 13:23:43 -0800	[thread overview]
Message-ID: <20111114132343.2ca2cdd9@jbarnes-desktop> (raw)
In-Reply-To: <1321303155-12624-1-git-send-email-eugeni.dodonov@intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1963 bytes --]

On Mon, 14 Nov 2011 18:39:14 -0200
Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:

> Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause
> any known regressions as of now.
> 
> Let's re-enable them by default to provide a wider testing and coverage.
> 
> Acked-by: Keith Packard <keithp@keithp.com>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> CC: Daniel Vetter <daniel.vetter@ffwll.ch>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index cc531bb..71f887a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -58,10 +58,10 @@ module_param_named(powersave, i915_powersave, int, 0600);
>  MODULE_PARM_DESC(powersave,
>  		"Enable powersavings, fbc, downclocking, etc. (default: true)");
>  
> -unsigned int i915_semaphores __read_mostly = 0;
> +unsigned int i915_semaphores __read_mostly = 1;
>  module_param_named(semaphores, i915_semaphores, int, 0600);
>  MODULE_PARM_DESC(semaphores,
> -		"Use semaphores for inter-ring sync (default: false)");
> +		"Use semaphores for inter-ring sync (default: true)");
>  
>  unsigned int i915_enable_rc6 __read_mostly = 0;
>  module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600);

I think we should keep them enabled; if one or two fat cats in the 1%
still have issues we can debug those without bringing down performance
for the other 99%.

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx