Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Eric Anholt <eric@anholt.net>
Cc: Ben Widawsky <ben@bwidawsk.net>,
	"drivers, Intel" <Intel-gfx@lists.freedesktop.org>
Subject: Re: Is MI_FLUSH_ENABLE bit 12?
Date: Tue, 6 Dec 2011 12:21:02 -0800	[thread overview]
Message-ID: <20111206122102.33ef6b44@jbarnes-desktop> (raw)
In-Reply-To: <87k469iieg.fsf@eliezer.anholt.net>


[-- Attachment #1.1: Type: text/plain, Size: 1225 bytes --]

On Tue, 06 Dec 2011 11:56:07 -0800
Eric Anholt <eric@anholt.net> wrote:
> > It's one of those "been there forever" bits.  A comment wouldn't hurt,
> > but we should also put in a doc change request (in fact I think I did
> > that but it went into a black hole).
> 
> Well, by "been there forever", you mean "introduced in:
> 
> commit a69ffdbfcba8eabf2ca9d384b578e6f28b339c61
> Author: Zhenyu Wang <zhenyuw@linux.intel.com>
> Date:   Mon Aug 30 16:12:42 2010 +0800
> 
>     drm/i915: Enable MI_FLUSH on Sandybridge
>     
>     MI_FLUSH is being deprecated, but still available on Sandybridge.
>     Make sure it's enabled as userspace still uses MI_FLUSH.
>     
>     Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
>     Cc: stable@kernel.org
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>"
> 
> It should be removed on Ironlake, and fixed to be 12 on SNB or just
> removed.

No, "fixed to be 12" would just encourage people to still try it and
break their machines.  We can safely remove it now that we don't use it
anywhere.  And we can fix the docs so that if people do want to mess
with it they won't try bit 12.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-12-06 20:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29  2:48 Is MI_FLUSH_ENABLE bit 12? Keith Packard
2011-11-30  0:47 ` Eric Anholt
2011-11-30  3:42   ` Ben Widawsky
2011-11-30  8:08     ` Keith Packard
2011-11-30 21:54     ` Eric Anholt
2011-12-05 22:57       ` Jesse Barnes
2011-12-06 19:56         ` Eric Anholt
2011-12-06 20:21           ` Jesse Barnes [this message]
2011-12-06 21:04             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206122102.33ef6b44@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=ben@bwidawsk.net \
    --cc=eric@anholt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox