From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add color key support v4
Date: Wed, 14 Dec 2011 00:00:11 +0100 [thread overview]
Message-ID: <20111213230011.GB18675@phenom.ffwll.local> (raw)
In-Reply-To: <20111213140911.2cba6c96@jbarnes-desktop>
On Tue, Dec 13, 2011 at 02:09:11PM -0800, Jesse Barnes wrote:
> Add new ioctls for getting and setting the current destination color
> key. This allows for simple overlay display control by matching a color
> key value in the primary plane before blending the overlay on top.
>
> v2: remove unnecessary mutex acquire/release around reg accesses
> v3: add support for full color key management
> v4: fix copy & paste bug in snb_get_colorkey
> don't bother checking min/max values against docs as the docs are likely
> wrong (how could we handle 10bpc surface formats?)
With the changes in v4 I can actually slap an r-b onto this and fix up
Jesse's a bit over-eager use of that tag ;-)
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-12-13 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 21:19 [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v6 Jesse Barnes
2011-12-13 21:19 ` [PATCH 2/3] drm/i915: track sprite coverage and disable primary plane if possible Jesse Barnes
2011-12-13 21:19 ` [PATCH 3/3] drm/i915: add color key support v3 Jesse Barnes
2011-12-13 22:09 ` [PATCH] drm/i915: add color key support v4 Jesse Barnes
2011-12-13 23:00 ` Daniel Vetter [this message]
2012-02-15 3:18 ` [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v6 Lan, Hai
2012-02-23 17:01 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213230011.GB18675@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox