From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Moving intel_decode.c to libdrm
Date: Wed, 21 Dec 2011 19:46:24 +0100 [thread overview]
Message-ID: <20111221184624.GD3827@phenom.ffwll.local> (raw)
In-Reply-To: <1324490983-6975-1-git-send-email-eric@anholt.net>
On Wed, Dec 21, 2011 at 10:09:30AM -0800, Eric Anholt wrote:
> I was once again embarassed while explaining to either Ken or Paul
> about how we handle reusing the intel_decode.c file in two trees.
> Here's my attempt at a solution to the problem: Move the code into
> libdrm, and try to give it an API that we won't have to continually
> rev as we throw the kitchen sink into the intel_decode() function
> arguments.
>
> One of the things I'm interested in is doing a version that directly
> pokes at BOs instead of just a pointer, which would let us decode
> associated blocks as we see the various state pointers to them.
> There's also room for some interesting validation in that case.
>
> Further patches (mostly fixing up style) are in my libdrm tree on the
> intel-decode branch. I've tested it with Mesa on gen7 (I have further
> code to land to make gen7 decode more reasonable).
I've only done a high-level cruise review of this series, but this is
awesome (and has been sitting on my todo list for way to long).
Very-Much-Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-12-21 18:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 18:09 Moving intel_decode.c to libdrm Eric Anholt
2011-12-21 18:09 ` [PATCH 01/13] intel: Import intel_decode.c from intel-gpu-tools Eric Anholt
2011-12-21 18:09 ` [PATCH 02/13] intel: Make intel_chipset handle devid directly Eric Anholt
2011-12-21 18:09 ` [PATCH 03/13] intel: intel: Add IS_GEN[567] macros Eric Anholt
2011-12-21 18:09 ` [PATCH 04/13] intel: Reformat intel_decode.c from intel-gpu-tools using Lindent Eric Anholt
2011-12-21 18:09 ` [PATCH 05/13] intel: Minor style tweaks after Lindent Eric Anholt
2011-12-21 18:09 ` [PATCH 06/13] intel: Get intel_decode.c minimally building Eric Anholt
2011-12-21 18:09 ` [PATCH 07/13] intel: Fix Wsigned-compare warnings (soon to be enabled) Eric Anholt
2011-12-21 18:09 ` [PATCH 08/13] intel: Fix a ton of signed vs unsigned and const char *warnings Eric Anholt
2011-12-21 18:09 ` [PATCH 09/13] intel: Add printflike warnings for instr_out Eric Anholt
2011-12-21 18:09 ` [PATCH 10/13] intel: Fix printf format warnings for intel_decode Eric Anholt
2011-12-21 18:09 ` [PATCH 11/13] intel: Remove c99ish variable declarations Eric Anholt
2011-12-21 18:09 ` [PATCH 12/13] intel: Turn on normal warnings for intel_decode.c build Eric Anholt
2011-12-21 18:09 ` [PATCH 13/13] intel: Disable unused decode_logic_op() Eric Anholt
2011-12-21 18:46 ` Daniel Vetter [this message]
2011-12-21 20:00 ` Moving intel_decode.c to libdrm Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221184624.GD3827@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox