From: Daniel Vetter <daniel@ffwll.ch>
To: przanoni@gmail.com
Cc: intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION
Date: Thu, 5 Jan 2012 17:27:07 +0100 [thread overview]
Message-ID: <20120105162707.GF3831@phenom.ffwll.local> (raw)
In-Reply-To: <1325780183-23690-1-git-send-email-przanoni@gmail.com>
On Thu, Jan 05, 2012 at 02:16:23PM -0200, przanoni@gmail.com wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> This ioctl is used to signal the drivers that the screen is rotated,
> not to make the drivers rotate the screen.
> - add a driver-specific "rotation_set" function
> - implement Intel's rotation_set by setting the right values to the
> PIPECONF registers.
>
> The idea is that when user-space does rotation, it can call this ioctl
> to inform the Kernel that we have a rotation. This feature is needed
> by the KVMr feature of VPro.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Quick comments before I dig into this:
- Please post at least a link to the userspace patches, so that it's
possible to check how this all fits together
- Please separate the generic infrastructre in drm from the changes to
support this in i915. I know, this is a rather small feature, but still.
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-05 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 16:16 [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION przanoni
2012-01-05 16:27 ` Daniel Vetter [this message]
2012-01-05 16:33 ` Paulo Zanoni
2012-01-05 16:40 ` Jakob Bornecrantz
2012-01-16 19:59 ` Paulo Zanoni
2012-01-16 20:35 ` [Intel-gfx] " Dave Airlie
2012-01-16 20:50 ` Paulo Zanoni
2012-01-05 16:44 ` Chris Wilson
2012-01-06 3:10 ` Eric Anholt
2012-01-06 15:26 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105162707.GF3831@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox