From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Sean Paul <seanpaul@chromium.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Only look for matching clocks for LVDS downclock
Date: Mon, 16 Jan 2012 12:20:03 -0800 [thread overview]
Message-ID: <20120116122003.576348dc@jbarnes-desktop> (raw)
In-Reply-To: <1326236976-7669-1-git-send-email-seanpaul@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 729 bytes --]
On Tue, 10 Jan 2012 15:09:36 -0800
Sean Paul <seanpaul@chromium.org> wrote:
> This patch enforces that the downclock clock source is the same as the preferred
> clock source for LVDS. This fixes a bug where the driver chooses a downclock
> clock source with a different P than the preferred mode clock source. This
> happened even if the preferred clock source implemented an acceptable rate for
> the downclock. The result of this bug is that downclock is disabled.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
Yeah looks like a good cleanup that also makes downclocking more likely.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-01-16 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 23:09 [PATCH] drm/i915: Only look for matching clocks for LVDS downclock Sean Paul
2012-01-16 20:20 ` Jesse Barnes [this message]
2012-01-16 20:21 ` Daniel Vetter
2012-01-16 21:56 ` Keith Packard
2012-01-16 22:10 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116122003.576348dc@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox