From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Only look for matching clocks for LVDS downclock
Date: Mon, 16 Jan 2012 21:21:45 +0100 [thread overview]
Message-ID: <20120116202145.GF3627@phenom.ffwll.local> (raw)
In-Reply-To: <20120116122003.576348dc@jbarnes-desktop>
On Mon, Jan 16, 2012 at 12:20:03PM -0800, Jesse Barnes wrote:
> On Tue, 10 Jan 2012 15:09:36 -0800
> Sean Paul <seanpaul@chromium.org> wrote:
>
> > This patch enforces that the downclock clock source is the same as the preferred
> > clock source for LVDS. This fixes a bug where the driver chooses a downclock
> > clock source with a different P than the preferred mode clock source. This
> > happened even if the preferred clock source implemented an acceptable rate for
> > the downclock. The result of this bug is that downclock is disabled.
> >
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
>
> Yeah looks like a good cleanup that also makes downclocking more likely.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-16 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 23:09 [PATCH] drm/i915: Only look for matching clocks for LVDS downclock Sean Paul
2012-01-16 20:20 ` Jesse Barnes
2012-01-16 20:21 ` Daniel Vetter [this message]
2012-01-16 21:56 ` Keith Packard
2012-01-16 22:10 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116202145.GF3627@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox