* [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p
[not found] <6d2c2dd7-0f25-4da2-9f48-c5772b039a9f@mail>
@ 2012-02-12 10:10 ` phil
2012-02-13 8:38 ` Daniel Vetter
2012-02-21 11:40 ` Philipp Grete
0 siblings, 2 replies; 6+ messages in thread
From: phil @ 2012-02-12 10:10 UTC (permalink / raw)
To: Keith Packard; +Cc: intel-gfx, torvalds, dri-devel
From: Philipp Grete <mail@pgrete.de>
Fixes LP: #796030 by removing forced pipe A on HP 2730p.
Quirk has previously been introduced to fix a sleep mode problem that does not exist any more.
Signed-off-by: Philipp Grete <mail@pgrete.de>
---
Fix has been confirmed by at least three people (see https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796030) who didn't experience any sleep mode problems after applying the patch.
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index daa5743..515a1cc 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8702,8 +8702,6 @@ struct intel_quirk {
};
struct intel_quirk intel_quirks[] = {
- /* HP Compaq 2730p needs pipe A force quirk (LP: #291555) */
- { 0x2a42, 0x103c, 0x30eb, quirk_pipea_force },
/* HP Mini needs pipe A force quirk (LP: #322104) */
{ 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p
2012-02-12 10:10 ` [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p phil
@ 2012-02-13 8:38 ` Daniel Vetter
2012-04-03 8:48 ` Daniel Vetter
2012-02-21 11:40 ` Philipp Grete
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2012-02-13 8:38 UTC (permalink / raw)
To: phil; +Cc: torvalds, intel-gfx, dri-devel
On Sun, Feb 12, 2012 at 11:10:32AM +0100, phil@haerkules.de wrote:
> From: Philipp Grete <mail@pgrete.de>
>
> Fixes LP: #796030 by removing forced pipe A on HP 2730p.
> Quirk has previously been introduced to fix a sleep mode problem that does not exist any more.
>
> Signed-off-by: Philipp Grete <mail@pgrete.de>
> ---
> Fix has been confirmed by at least three people (see
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796030) who didn't
> experience any sleep mode problems after applying the patch.
Can you please supply the corresponding tested-bys for these three people?
I.e. add
Tested-by: Name <mail@address.com>
to the sob part of your commit message. Also please add a reference to the
LP as a full link (easier to handle for people outside of the ubuntu
universe):
Bugzilla: http://launchpad/direct/link/to/bug
Thanks, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p
2012-02-12 10:10 ` [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p phil
2012-02-13 8:38 ` Daniel Vetter
@ 2012-02-21 11:40 ` Philipp Grete
2012-02-21 19:59 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Philipp Grete @ 2012-02-21 11:40 UTC (permalink / raw)
To: intel-gfx
From: Philipp Grete <mail@pgrete.de>
Fixes LP: #796030 by removing forced pipe A on HP 2730p.
Quirk has previously been introduced to fix a sleep mode problem that does not exist any more.
Bugzilla: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796030
Tested-by: Ronny Standtke <ronny.standtke@gmx.net>
Signed-off-by: Philipp Grete <mail@pgrete.de>
v2: Added Tested-by and Bugzilla Link
---
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index daa5743..515a1cc 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8702,8 +8702,6 @@ struct intel_quirk {
};
struct intel_quirk intel_quirks[] = {
- /* HP Compaq 2730p needs pipe A force quirk (LP: #291555) */
- { 0x2a42, 0x103c, 0x30eb, quirk_pipea_force },
/* HP Mini needs pipe A force quirk (LP: #322104) */
{ 0x27ae, 0x103c, 0x361a, quirk_pipea_force },
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p
2012-02-21 11:40 ` Philipp Grete
@ 2012-02-21 19:59 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2012-02-21 19:59 UTC (permalink / raw)
To: Philipp Grete; +Cc: intel-gfx
On Tue, Feb 21, 2012 at 12:40:20PM +0100, Philipp Grete wrote:
j From: Philipp Grete <mail@pgrete.de>
>
> Fixes LP: #796030 by removing forced pipe A on HP 2730p.
> Quirk has previously been introduced to fix a sleep mode problem that does not exist any more.
>
> Bugzilla: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796030
>
> Tested-by: Ronny Standtke <ronny.standtke@gmx.net>
>
> Signed-off-by: Philipp Grete <mail@pgrete.de>
>
> v2: Added Tested-by and Bugzilla Link
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p
2012-02-13 8:38 ` Daniel Vetter
@ 2012-04-03 8:48 ` Daniel Vetter
2012-04-03 8:55 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2012-04-03 8:48 UTC (permalink / raw)
To: phil; +Cc: torvalds, intel-gfx, dri-devel
On Mon, Feb 13, 2012 at 09:38:33AM +0100, Daniel Vetter wrote:
> On Sun, Feb 12, 2012 at 11:10:32AM +0100, phil@haerkules.de wrote:
> > From: Philipp Grete <mail@pgrete.de>
> >
> > Fixes LP: #796030 by removing forced pipe A on HP 2730p.
> > Quirk has previously been introduced to fix a sleep mode problem that does not exist any more.
> >
> > Signed-off-by: Philipp Grete <mail@pgrete.de>
> > ---
> > Fix has been confirmed by at least three people (see
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796030) who didn't
> > experience any sleep mode problems after applying the patch.
>
> Can you please supply the corresponding tested-bys for these three people?
> I.e. add
>
> Tested-by: Name <mail@address.com>
>
> to the sob part of your commit message. Also please add a reference to the
> LP as a full link (easier to handle for people outside of the ubuntu
> universe):
>
> Bugzilla: http://launchpad/direct/link/to/bug
Ping.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p
2012-04-03 8:48 ` Daniel Vetter
@ 2012-04-03 8:55 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2012-04-03 8:55 UTC (permalink / raw)
To: phil; +Cc: torvalds, intel-gfx, dri-devel
On Tue, Apr 3, 2012 at 10:48, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Feb 13, 2012 at 09:38:33AM +0100, Daniel Vetter wrote:
>> On Sun, Feb 12, 2012 at 11:10:32AM +0100, phil@haerkules.de wrote:
>> > From: Philipp Grete <mail@pgrete.de>
>> >
>> > Fixes LP: #796030 by removing forced pipe A on HP 2730p.
>> > Quirk has previously been introduced to fix a sleep mode problem that does not exist any more.
>> >
>> > Signed-off-by: Philipp Grete <mail@pgrete.de>
>> > ---
>> > Fix has been confirmed by at least three people (see
>> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/796030) who didn't
>> > experience any sleep mode problems after applying the patch.
>>
>> Can you please supply the corresponding tested-bys for these three people?
>> I.e. add
>>
>> Tested-by: Name <mail@address.com>
>>
>> to the sob part of your commit message. Also please add a reference to the
>> LP as a full link (easier to handle for people outside of the ubuntu
>> universe):
>>
>> Bugzilla: http://launchpad/direct/link/to/bug
>
> Ping.
Disregard that ping, I've noticed that I've already picked this up.
Cheers, Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-03 8:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <6d2c2dd7-0f25-4da2-9f48-c5772b039a9f@mail>
2012-02-12 10:10 ` [PATCH 3.3-rc3] drm/i915: Fixes distorted external screen image on HP 2730p phil
2012-02-13 8:38 ` Daniel Vetter
2012-04-03 8:48 ` Daniel Vetter
2012-04-03 8:55 ` Daniel Vetter
2012-02-21 11:40 ` Philipp Grete
2012-02-21 19:59 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox