Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Reese, Armin C" <armin.c.reese@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Mask reserved bits in display/sprite address registers
Date: Tue, 17 Apr 2012 08:50:52 -0700	[thread overview]
Message-ID: <20120417085052.4937c512@jbarnes-desktop> (raw)
In-Reply-To: <07EEC142D30DAC40BA4DD9C0F9EE51090E5110@FMSMSX102.amr.corp.intel.com>

On Mon, 16 Apr 2012 21:02:41 +0000
"Reese, Armin C" <armin.c.reese@intel.com> wrote:

> Corrected my name in the patch (acreese -> Armin Reese) ...
> 
> The attached patch file was updated to reflect reviewer's comments.  The only change I did not make was using PAGE_MASK instead of DISP_BASEADDR_MASK.  PAGE_MASK is CPU architecture dependent and I didn't want to tie our GPU addressing arch to that of the CPU.

Looks good, thanks Armin.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2012-04-17 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 20:32 [PATCH] drm/i915: Mask reserved bits in display/sprite address registers Reese, Armin C
2012-04-16 21:02 ` Reese, Armin C
2012-04-17 15:50   ` Jesse Barnes [this message]
2012-04-17 15:55   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120417085052.4937c512@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=armin.c.reese@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox