From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: intel_update_fbc() requires struct_mutex, so no longer atomic
Date: Wed, 18 Apr 2012 12:02:18 +0200 [thread overview]
Message-ID: <20120418100218.GM5315@phenom.ffwll.local> (raw)
In-Reply-To: <20120417084906.7de696f0@jbarnes-desktop>
On Tue, Apr 17, 2012 at 08:49:06AM -0700, Jesse Barnes wrote:
> On Tue, 17 Apr 2012 15:08:19 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > As we need to manipulate our device structure and allocate queue a task,
> > it is no longer a simple atomic operation and cannot be performed along
> > the atomic modeset paths. Instead make sure that we disable FBC (which
> > must be therefore kept as a set of simple register writes) when
> > performing the atomic modeset and leave the heavy-weight
> > intel_update_fbc() for the normal modeset.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
>
> Looks good.
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-04-18 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:08 [PATCH] drm/i915: intel_update_fbc() requires struct_mutex, so no longer atomic Chris Wilson
2012-04-17 15:49 ` Jesse Barnes
2012-04-18 10:02 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418100218.GM5315@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox