public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: manage PCH PLLs separately from pipes
Date: Wed, 18 Apr 2012 23:36:08 +0200	[thread overview]
Message-ID: <20120418212920.GA2091@phenom.ffwll.local> (raw)
In-Reply-To: <1334337878-32566-1-git-send-email-chris@chris-wilson.co.uk>

On Fri, Apr 13, 2012 at 06:24:38PM +0100, Chris Wilson wrote:
> From: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> PCH PLLs aren't required for outputs on the CPU, so we shouldn't just
> treat them as part of the pipe.
> 
> So split the code out and manage PCH PLLs separately, allocating them
> when needed or trying to re-use existing PCH PLL setups when the timings
> match.
> 
> v2: add num_pch_pll field to dev_priv (Daniel)
>     don't NULL the pch_pll pointer in disable or DPMS will fail (Jesse)
>     put register offsets in pll struct (Chris)
> 
> v3: Decouple enable/disable of PLLs from get/put.
> 
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=44309
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Patch applied to dinq with Jesse's irc reviewed-by and tested-by, thanks
for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  parent reply	other threads:[~2012-04-18 21:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 21:16 [PATCH] drm/i915: manage PCH PLLs separately from pipes Jesse Barnes
2012-04-13 17:24 ` Chris Wilson
2012-04-18 16:55   ` Jesse Barnes
2012-04-18 21:36   ` Daniel Vetter [this message]
2012-04-20  7:30     ` Daniel Vetter
2012-04-20  7:48       ` Chris Wilson
2012-04-20  7:52         ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2012-04-20  8:59 Chris Wilson
2012-04-20 15:33 ` Eugeni Dodonov
2012-04-20 15:45   ` Chris Wilson
2012-04-20 16:11 ` Chris Wilson
2012-04-23 13:59   ` Eugeni Dodonov
2012-04-23 21:08     ` Eugeni Dodonov
2012-04-23 21:05   ` Jesse Barnes
2012-04-23 21:11   ` Daniel Vetter
2012-04-11 18:36 Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418212920.GA2091@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox