Re: [PATCH] drm/i915: manage PCH PLLs separately from pipes

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Apr 20, 2012 at 05:11:53PM +0100, Chris Wilson wrote:
> From: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> PCH PLLs aren't required for outputs on the CPU, so we shouldn't just
> treat them as part of the pipe.
> 
> So split the code out and manage PCH PLLs separately, allocating them
> when needed or trying to re-use existing PCH PLL setups when the timings
> match.
> 
> v2: add num_pch_pll field to dev_priv (Daniel)
>     don't NULL the pch_pll pointer in disable or DPMS will fail (Jesse)
>     put register offsets in pll struct (Chris)
> 
> v3: Decouple enable/disable of PLLs from get/put.
> v4: Track temporary PLL disabling during modeset
> v5: Tidy PLL initialisation by only checking for num_pch_pll == 0 (Eugeni)
> v6: Avoid mishandling allocation failure by embedding the small array of
>     PLLs into the device struct
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44309
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> (up to v2)
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> (v3+)
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48