From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Only the zap the VMA after updating the tiling parameters
Date: Sun, 22 Apr 2012 14:53:42 +0200 [thread overview]
Message-ID: <20120422125342.GG4723@phenom.ffwll.local> (raw)
In-Reply-To: <1335021804-31847-2-git-send-email-chris@chris-wilson.co.uk>
On Sat, Apr 21, 2012 at 04:23:24PM +0100, Chris Wilson wrote:
> If we fail to unbind and so abort the change in tiling, we will have
> removed the VMA for the object for no reason. The likelihood of unbind
> failing is slim (other than ERESTARTSYS which will cause userspace to
> try again), so the change is mostly for the principle.
>
> Also improve the slightly stale comment.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued both for -next (with some bikeshed on the commit message for the
first patch), thanks for the patches.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-04-22 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 15:23 [PATCH 1/2] drm/i915: Clarify the semantics of tiling-changed by renaming it Chris Wilson
2012-04-21 15:23 ` [PATCH 2/2] drm/i915: Only the zap the VMA after updating the tiling parameters Chris Wilson
2012-04-22 12:53 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120422125342.GG4723@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox