From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use a global lock for modifying global irq flags
Date: Wed, 25 Apr 2012 10:21:28 +0200 [thread overview]
Message-ID: <20120425082128.GA5079@phenom.ffwll.local> (raw)
In-Reply-To: <20120424140525.51344200@bwidawsk.net>
On Tue, Apr 24, 2012 at 02:05:25PM -0700, Ben Widawsky wrote:
> On Tue, 24 Apr 2012 21:48:47 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > We were attempting to use a per-ring spinlock whilst modifying global
> > IRQ flags. A recipe for rare missed interrupts.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Regardless of whether or not this currently fixes anything, I need this
> for an upcoming patch.
>
> Acked-by: Ben Widawsky <ben@bwidawsk.net>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-04-25 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 20:48 [PATCH] drm/i915: Use a global lock for modifying global irq flags Chris Wilson
2012-04-24 21:05 ` Ben Widawsky
2012-04-25 8:21 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425082128.GA5079@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox