From: Ben Widawsky <ben@bwidawsk.net>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: wait render timeout ioctl
Date: Tue, 1 May 2012 11:08:44 -0700 [thread overview]
Message-ID: <20120501110844.54e34526@bwidawsk.net> (raw)
In-Reply-To: <87ehr3rf7q.fsf@eliezer.anholt.net>
On Tue, 01 May 2012 10:19:53 -0700
Eric Anholt <eric@anholt.net> wrote:
> On Mon, 30 Apr 2012 18:41:08 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > This helps implement GL_ARB_sync put stops short of allowing full blow
> "but"? "blown"?
>
> > sync objects.
> >
> > Finally we can use the new timed seqno waiting function to allow
> > userspace to wait on a request with a timeout. This implements that
> > interface.
>
> It looks like this actually lets them wait on a BO with a timeout. I
> like it as an interface, but that's not what I expected from the commit
> message. Waiting on a request sounds like passing a seqno back out to
> userland that they could wait on.
Yeah. Chris asked me to update the comments actually, and I forgot. I
will resubmit this patch with better comments in the not too distant
future.
next prev parent reply other threads:[~2012-05-01 18:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 22:22 [PATCH 0/5 v3] timed BO wait Ben Widawsky
2012-04-29 22:22 ` [PATCH 1/5 v2] drm/i915: timeout parameter for seqno wait Ben Widawsky
2012-05-01 1:39 ` [PATCH 1/5] " Ben Widawsky
2012-05-02 21:47 ` Daniel Vetter
2012-05-03 4:32 ` Ben Widawsky
2012-04-29 22:22 ` [PATCH 2/5] drm/i915: make waiting trace events more useful Ben Widawsky
2012-05-01 1:40 ` Ben Widawsky
2012-05-02 21:12 ` Daniel Vetter
2012-05-02 21:22 ` Chris Wilson
2012-05-02 21:36 ` Daniel Vetter
2012-05-02 21:56 ` Daniel Vetter
2012-04-29 22:22 ` [PATCH 3/5 v2] drm/i915: extract some common olr+wedge code Ben Widawsky
2012-05-02 21:08 ` Daniel Vetter
2012-04-29 22:22 ` [PATCH 4/5 v3] drm/i915: wait render timeout ioctl Ben Widawsky
2012-05-01 1:41 ` [PATCH 4/5] " Ben Widawsky
2012-05-01 17:19 ` Eric Anholt
2012-05-01 18:08 ` Ben Widawsky [this message]
2012-05-02 21:26 ` Daniel Vetter
2012-04-29 22:22 ` [PATCH 5/5] drm/i915: s/i915_wait_reqest/i915_wait_seqno/g Ben Widawsky
2012-04-29 22:22 ` [PATCH] intel: add a timed wait function Ben Widawsky
2012-04-29 22:22 ` [PATCH] tests/wait render timeout test Ben Widawsky
2012-05-03 5:49 ` [PATCH 0/5 v3] timed BO wait Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501110844.54e34526@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox