From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not read non-existent DPLL registers on PCH hardware
Date: Wed, 2 May 2012 14:35:34 +0200 [thread overview]
Message-ID: <20120502123534.GC5089@phenom.ffwll.local> (raw)
In-Reply-To: <1335956826-22460-1-git-send-email-chris@chris-wilson.co.uk>
On Wed, May 02, 2012 at 12:07:06PM +0100, Chris Wilson wrote:
> We only execute intel_decrease_pllclock for pre-PCH hardware, typically
> gen4 mobiles. However, in the variable declaration we did read from the
> non-PCH DPLL register, quite naughty and detected by SandyBridge.
>
> Reported-by: Andrey Rahmatullin <wrar@wrar.name>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=49025
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Picked up for -fixes (with Andrey's tested-by added), thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-05-02 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 11:07 [PATCH] drm/i915: Do not read non-existent DPLL registers on PCH hardware Chris Wilson
2012-05-02 12:35 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502123534.GC5089@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox