From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: rip out intel_dpio_write again
Date: Thu, 3 May 2012 11:10:36 +0200 [thread overview]
Message-ID: <20120503091005.GA4983@phenom.ffwll.local> (raw)
In-Reply-To: <20120502172219.41bd6035@jbarnes-desktop>
On Wed, May 02, 2012 at 05:22:19PM -0700, Jesse Barnes wrote:
> On Wed, 2 May 2012 13:18:56 -0700
> Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > On Wed, 2 May 2012 11:55:48 -0700
> > Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >
> > > On Wed, 2 May 2012 08:44:27 -0700
> > > Ben Widawsky <ben@bwidawsk.net> wrote:
> > >
> > > > On Wed, 2 May 2012 11:06:23 +0200
> > > > Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > >
> > > > > Unfortunately it looks like further vlv patches are still stalled due
> > > > > to fried hw, and too many people are a bit annoyed about the unused
> > > > > function warning.
> > > >
> > > > It is my preference that you never merge code which you know will
> > > > produce a warning. I still stand by adding a __used for intermediate
> > > > patches.
> > >
> > > Well he could have just merged the other patches too, but nooo...
> > >
> >
> > Twasn't a shot at you... shot was fired at Daniel (although if you *did*
> > but in __used I wouldn't have had to shoot at Daniel).
>
> Meh ok you can kill this function. Vijay will be re-posting the code
> that uses it (and adds it again) once he gets his hardware, unless I
> beat him to it (still waiting on a new CPU).
I guess that counts as an ack ... patch merged for -next.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-05-03 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 9:06 [PATCH] drm/i915: rip out intel_dpio_write again Daniel Vetter
2012-05-02 15:44 ` Ben Widawsky
2012-05-02 18:55 ` Jesse Barnes
2012-05-02 20:18 ` Ben Widawsky
2012-05-03 0:22 ` Jesse Barnes
2012-05-03 9:10 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503091005.GA4983@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox