From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915: Handle framebuffer offsets[]
Date: Thu, 24 May 2012 11:31:32 -0700 [thread overview]
Message-ID: <20120524113132.5a7e6f6c@jbarnes-desktop> (raw)
In-Reply-To: <1337882939-22274-6-git-send-email-ville.syrjala@linux.intel.com>
On Thu, 24 May 2012 21:08:58 +0300
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Take fb->offset[0] into account when calculating the linear and tile x/y
> offsets.
>
> For non-tiled surfaces fb->offset[0] is simply added to the linear
> byte offset.
>
> For tiled surfaces treat fb->offsets[0] as a byte offset into the
> linearized view of the surface. So we end up converting fb->offsets[0]
> into additional x and y offsets.
Do you have code using a non-zero offsets[0]? At least for current
code that would indicate some kind of problem... though hopefully we'll
be adding planar support back again sometime soon.
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-05-24 18:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 18:08 [PATCH 0/6] drm/i915: Framebuffer layout fixes and sanity checks ville.syrjala
2012-05-24 18:08 ` [PATCH 1/6] drm/i915: Fix display pixel format handling ville.syrjala
2012-05-24 18:08 ` [PATCH 2/6] drm/i915: Check framebuffer stride more thoroughly ville.syrjala
2012-07-05 11:27 ` Daniel Vetter
2012-07-05 11:59 ` [Intel-gfx] " Ville Syrjälä
2012-05-24 18:08 ` [PATCH 3/6] drm/i915: Zero initialize mode_cmd ville.syrjala
2012-07-05 11:28 ` Daniel Vetter
2012-05-24 18:08 ` [PATCH 4/6] drm/i915: Check the framebuffer offset ville.syrjala
2012-05-24 18:08 ` [PATCH 5/6] drm/i915: Handle framebuffer offsets[] ville.syrjala
2012-05-24 18:31 ` Jesse Barnes [this message]
2012-05-24 18:49 ` Ville Syrjälä
2012-05-24 19:01 ` [Intel-gfx] " Daniel Vetter
2012-07-05 11:29 ` Daniel Vetter
2012-07-05 12:01 ` [Intel-gfx] " Ville Syrjälä
2012-05-24 18:08 ` [PATCH 6/6] drm/i915: Reject page flips with changed format/offset/pitch ville.syrjala
2012-07-05 11:31 ` [Intel-gfx] " Daniel Vetter
2012-07-19 12:27 ` Laurent Pinchart
2012-07-19 12:39 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524113132.5a7e6f6c@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox