From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: reuse the sdvo tv clock adjustment in ilk mode_set
Date: Thu, 31 May 2012 09:31:57 +0200 [thread overview]
Message-ID: <20120531073156.GC4953@phenom.ffwll.local> (raw)
In-Reply-To: <1338382593_357080@CP5-2952>
On Wed, May 30, 2012 at 01:56:01PM +0100, Chris Wilson wrote:
> On Wed, 30 May 2012 14:52:26 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Jesse extracted this nice helper in his i9xx_crtc_mode_set refactor,
> > but we have the identical code in ironlake_ccrtc_mode_set. And that
> > function is huge, so extracting some code full of magic numbers is
> > always nice.
> >
> > Noticed while trying to get a handle on our dp clock code.
> >
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-05-31 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 12:52 [PATCH] drm/i915: reuse the sdvo tv clock adjustment in ilk mode_set Daniel Vetter
2012-05-30 12:56 ` Chris Wilson
2012-05-31 7:31 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531073156.GC4953@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox