From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: l3 parity sysfs interface
Date: Thu, 31 May 2012 08:55:53 -0700 [thread overview]
Message-ID: <20120531085553.12e7eab3@bwidawsk.net> (raw)
In-Reply-To: <20120531104556.GE4953@phenom.ffwll.local>
On Thu, 31 May 2012 12:45:56 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, May 25, 2012 at 04:56:25PM -0700, Ben Widawsky wrote:
> > Dumb binary interfaces which allow root-only updates of the cache
> > remapping registers. As mentioned in a previous patch, software using
> > this interface needs to know about HW limits, and other programming
> > considerations as the kernel interface does no checking for these things
> > on the root-only interface.
> >
> > v1: Drop extra posting reads (Chris)
> > Return negative values in the sysfs interfaces on errors (Chris)
> >
> > v2: Return -EINVAL for offset % 4 (Jesse)
> > Move schizo userspace check out (Jesse)
> > Cleaner sysfs item initializers (Daniel)
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> I've queued this series for -next. Although you haven't fixed up the one
> issue in patch 2 I've noticed and I also don't see my bikeshed for this
> patch (despite that you claim to have done so). Whatever, I'll follow up
> with patches.
> -Daniel
Thanks for moving the patches forward, I'll review your fixes to them
shortly. The fixes are somewhere; I am not sure how they got lost.
next prev parent reply other threads:[~2012-05-31 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 23:56 [PATCH 1/4 v2] drm/i915: Dynamic Parity Detection handling Ben Widawsky
2012-05-25 23:56 ` [PATCH 2/4] drm/i915: enable parity error interrupts Ben Widawsky
2012-05-25 23:56 ` [PATCH 3/4 v2] drm/i915: remap l3 on hw init Ben Widawsky
2012-05-25 23:56 ` [PATCH 4/4] drm/i915: l3 parity sysfs interface Ben Widawsky
2012-05-31 10:45 ` Daniel Vetter
2012-05-31 15:55 ` Ben Widawsky [this message]
2012-07-27 4:19 ` Zhang, Xiong Y
2012-07-27 16:50 ` Ben Widawsky
2012-05-25 23:56 ` [PATCH 5/6] tools/dpf: Tool to read and write l3 remap registers Ben Widawsky
2012-05-28 20:16 ` Paul Menzel
2012-05-25 23:56 ` [PATCH 6/6] tests/dpf: simple dpf test Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531085553.12e7eab3@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox