From: Daniel Vetter <daniel@ffwll.ch>
To: eugeni.dodonov@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: pch_irq_handler -> {ibx, cpt}_irq_handler
Date: Wed, 6 Jun 2012 23:02:33 +0200 [thread overview]
Message-ID: <20120606210233.GH4699@phenom.ffwll.local> (raw)
In-Reply-To: <4FCFC00D.7070701@linux.intel.com>
On Wed, Jun 06, 2012 at 05:39:41PM -0300, Eugeni Dodonov wrote:
> On 06/06/2012 04:45 PM, Adam Jackson wrote:
> >Cougar/Panther Point redefine the bits in SDEIIR pretty completely.
> >This function is just debugging, but if we're debugging we probably want
> >to be told accurate things instead of lies.
> >
> >I'm told Lynx Point changes this yet more, but I have no idea how...
> >
> >Signed-off-by: Adam Jackson <ajax@redhat.com>
>
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
>
> For the record and for future enabling efforts, for LPT, bits 28-31
> and 1-14 are gone since CPT/PPT (e.g., those must be zero). And
> there is the bit 15 as a new addition, but we are not using it yet
> and probably won't be using in foreseeable future.
Picked up for -fixes with Eugeni's comment added, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-06-06 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 19:45 [PATCH] drm/i915: pch_irq_handler -> {ibx, cpt}_irq_handler Adam Jackson
2012-06-06 20:01 ` Daniel Vetter
2012-06-06 20:39 ` Eugeni Dodonov
2012-06-06 21:02 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606210233.GH4699@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox