From: Ben Widawsky <ben@bwidawsk.net>
To: Kenneth Graunke <kenneth@whitecape.org>
Cc: Mesa Dev <mesa-dev@lists.freedesktop.org>,
intel-gfx@lists.freedesktop.org,
DRI Devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 00/25] i915 HW context support
Date: Thu, 7 Jun 2012 09:17:49 -0700 [thread overview]
Message-ID: <20120607091749.792965a5@bwidawsk.net> (raw)
In-Reply-To: <4FCE9830.90201@whitecape.org>
On Tue, 05 Jun 2012 16:37:20 -0700
Kenneth Graunke <kenneth@whitecape.org> wrote:
> On 06/04/2012 02:42 PM, Ben Widawsky wrote:
> > Setting myself up for a late night crying session once again. Most of the
> > people reading this probably know the history and reasons for the patches. If
> > not, you can search the intel-gfx mailing list to try to learn more. I won't
> > recap the whole thing here, and instead let the patches speak for themselves.
> >
> > Instead a brief review of what's here, and what's happened. Mostly,
> > these badly need testing and review. I've carried these around for so
> > long now, and seen so many different failures, I'm quite paranoid they
> > still aren't perfect. Also, I've spent almost all of the time working on
> > this in the kernel, so there is bound to be simple errors in the other
> > stuff.
> >
> > I've run these on various workloads and saw nothing worth mentioning.
> >
> >
> > 0-16: kernel patches
>
> > 17-21: libdrm patches (wait render patch is temporary)
>
> Patches 17-21 look fine.
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
>
> > 22-24: intel-gpu-tools
> > 25: mesa
>
> Patch 25 looks fine too. Feel free to apply some combination of:
> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
>
> I do like Paul's comment updates, so I suggest merging those.
Ken, would you do these for me on patch 25? It's really your patch
anyhow, I just made ever so slight modifications :-)
>
> > kernel
> > git://people.freedesktop.org/~bwidawsk/drm-intel context_support_rev2
> >
> > libdrm
> > git://people.freedesktop.org/~bwidawsk/drm context_support_rev2
> >
> > i-g-t
> > git://people.freedesktop.org/~bwidawsk/intel-gpu-tools context_support
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-06-07 16:17 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 21:42 [PATCH 00/25] i915 HW context support Ben Widawsky
2012-06-04 21:42 ` [PATCH 01/25] drm/i915: CXT_SIZE register offsets added Ben Widawsky
2012-06-04 21:42 ` [PATCH 02/25 v2] drm/i915: preliminary context support Ben Widawsky
2012-06-05 12:23 ` Ville Syrjälä
2012-06-05 16:30 ` Ben Widawsky
2012-06-04 21:42 ` [PATCH 03/25 v2] drm/i915: context basic create & destroy Ben Widawsky
2012-06-13 23:27 ` Ben Widawsky
2012-06-04 21:42 ` [PATCH 04/25] drm/i915: add context information to objects Ben Widawsky
2012-06-13 22:01 ` Daniel Vetter
2012-06-13 23:26 ` Ben Widawsky
2012-06-04 21:42 ` [PATCH 05/25] drm/i915: always bind context objects immediately Ben Widawsky
2012-06-04 21:42 ` [PATCH 06/25 v3] drm/i915: context switch implementation Ben Widawsky
2012-06-04 21:42 ` [PATCH 07/25] drm/i915: context trace events Ben Widawsky
2012-06-13 22:23 ` Daniel Vetter
2012-06-13 23:27 ` Ben Widawsky
2012-06-04 21:42 ` [PATCH 08/25] drm/i915: Ivybridge MI_ARB_ON_OFF context w/a Ben Widawsky
2012-06-04 21:42 ` [PATCH 09/25] drm/i915: PIPE_CONTROL_TLB_INVALIDATE Ben Widawsky
2012-06-04 21:42 ` [PATCH 10/25 v2] drm/i915: possibly invalidate TLB before context switch Ben Widawsky
2012-06-04 21:42 ` [PATCH 11/25] drm/i915: use the default context Ben Widawsky
2012-06-04 21:42 ` [PATCH 12/25] drm/i915: add ccid to error state Ben Widawsky
2012-06-04 21:42 ` [PATCH 13/25 v3] drm/i915: switch to default context on idle Ben Widawsky
2012-06-04 21:42 ` [PATCH 14/25 v3] drm/i915/context: create & destroy ioctls Ben Widawsky
2012-06-04 21:42 ` [PATCH 15/25 v2] drm/i915/context: switch contexts with execbuf2 Ben Widawsky
2012-06-04 21:42 ` [PATCH 16/25] drm/i915: reset the GPU on context fini Ben Widawsky
2012-06-04 21:42 ` [PATCH 17/25] intel: wait render placeholder Ben Widawsky
2012-06-04 21:42 ` [PATCH 18/25] intel: Merge updated kernel header Ben Widawsky
2012-06-04 21:42 ` [PATCH 19/25] intel/context: Add drm_intel_context type Ben Widawsky
2012-06-04 21:43 ` [PATCH 20/25] intel/context: new execbuf interface for contexts Ben Widawsky
2012-06-04 21:43 ` [PATCH 21/25] intel: add decoding of MI_SET_CONTEXT Ben Widawsky
2012-06-04 21:43 ` [PATCH 22/25] context: libdrm wrappers Ben Widawsky
2012-06-04 21:43 ` [PATCH 23/25] context: update for new execbuf2 element Ben Widawsky
2012-06-04 21:43 ` [PATCH 24/25] contexts: basic test coverage Ben Widawsky
2012-06-13 23:30 ` Daniel Vetter
2012-06-14 3:13 ` [PATCH] " Ben Widawsky
2012-06-04 21:43 ` [PATCH 25/25] i965: hw context support Ben Widawsky
2012-06-04 23:01 ` Paul Berry
2012-06-04 23:10 ` [Intel-gfx] " Ben Widawsky
2012-06-05 5:53 ` [PATCH 00/25] i915 HW " Dave Airlie
2012-06-05 7:08 ` [Mesa-dev] " Kenneth Graunke
2012-06-05 16:32 ` Ben Widawsky
2012-06-05 23:37 ` Kenneth Graunke
2012-06-07 16:17 ` Ben Widawsky [this message]
2012-06-14 16:04 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607091749.792965a5@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox