From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: cache the EDID for eDP panels
Date: Fri, 15 Jun 2012 19:41:28 +0200 [thread overview]
Message-ID: <20120615174128.GB4799@phenom.ffwll.local> (raw)
In-Reply-To: <20120615103106.730ab802@jbarnes-desktop>
On Fri, Jun 15, 2012 at 10:31:06AM -0700, Jesse Barnes wrote:
> On Fri, 15 Jun 2012 10:34:22 +0300
> Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > Hi Jesse, I'm sure you meant to do *something* with that return value. I
> > presume it should be equal to intel_dp->edid_mode_count, but is it
> > possible it's not? Is it better to return ret or
> > intel_dp->edid_mode_count from this function?
> >
>
> Heh there's always something... but yeah it should be equal to the
> mode_count; I should either drop the ret= or use it. Maybe as a
> cleanup on top since I'm tired of respinning this one? :p
I guess we can mend that bikeshed when we unify the panel handling some
more between lvds and eDP. Patch merged for -fixes, thanks.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-06-15 17:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 19:28 [PATCH] drm/i915: cache the EDID for eDP panels Jesse Barnes
2012-06-14 19:42 ` Chris Wilson
2012-06-14 19:44 ` Jesse Barnes
2012-06-15 7:34 ` Jani Nikula
2012-06-15 17:31 ` Jesse Barnes
2012-06-15 17:41 ` Daniel Vetter [this message]
2012-06-15 8:21 ` Chris Wilson
2012-06-15 10:52 ` Jani Nikula
2012-06-15 10:55 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2012-06-14 19:02 Jesse Barnes
2012-06-14 18:30 Jesse Barnes
2012-06-14 18:37 ` Chris Wilson
2012-06-14 18:55 ` Jesse Barnes
2012-06-14 17:19 Jesse Barnes
2012-06-05 20:54 Jesse Barnes
2012-06-05 21:02 ` Chris Wilson
2012-06-05 21:26 ` Jesse Barnes
2012-06-05 21:38 ` Chris Wilson
2012-06-05 21:41 ` Jesse Barnes
2012-06-06 7:23 ` Daniel Vetter
2012-06-06 7:23 ` Jani Nikula
2012-06-06 7:36 ` Takashi Iwai
2012-06-14 17:20 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615174128.GB4799@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox