* [PATCH] drm/i915: mask tiled bit when updating ILK sprites
@ 2012-07-13 12:50 Ander Conselvan de Oliveira
2012-07-13 13:26 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Ander Conselvan de Oliveira @ 2012-07-13 12:50 UTC (permalink / raw)
To: intel-gfx; +Cc: Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Or going from tiled to untiled may break.
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
drivers/gpu/drm/i915/intel_sprite.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 1a1483b..cc8df4d 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -234,6 +234,7 @@ ilk_update_plane(struct drm_plane *plane, struct drm_framebuffer *fb,
dvscntr &= ~DVS_PIXFORMAT_MASK;
dvscntr &= ~DVS_RGB_ORDER_XBGR;
dvscntr &= ~DVS_YUV_BYTE_ORDER_MASK;
+ dvscntr &= ~DVS_TILED;
switch (fb->pixel_format) {
case DRM_FORMAT_XBGR8888:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: mask tiled bit when updating ILK sprites
2012-07-13 12:50 [PATCH] drm/i915: mask tiled bit when updating ILK sprites Ander Conselvan de Oliveira
@ 2012-07-13 13:26 ` Chris Wilson
2012-07-13 15:06 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-07-13 13:26 UTC (permalink / raw)
To: Ander Conselvan de Oliveira, intel-gfx; +Cc: Ander Conselvan de Oliveira
On Fri, 13 Jul 2012 15:50:33 +0300, Ander Conselvan de Oliveira <conselvan2@gmail.com> wrote:
> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>
> Or going from tiled to untiled may break.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: mask tiled bit when updating ILK sprites
2012-07-13 13:26 ` Chris Wilson
@ 2012-07-13 15:06 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-07-13 15:06 UTC (permalink / raw)
To: Chris Wilson; +Cc: Ander Conselvan de Oliveira, intel-gfx
On Fri, Jul 13, 2012 at 02:26:54PM +0100, Chris Wilson wrote:
> On Fri, 13 Jul 2012 15:50:33 +0300, Ander Conselvan de Oliveira <conselvan2@gmail.com> wrote:
> > From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >
> > Or going from tiled to untiled may break.
> >
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch. For some odd reason I've thought
I've reviewed the other sprite implementations when I've merged Jesse's
identical fix for ivb. But alas, I've failed, thanks for catching this.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-13 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-13 12:50 [PATCH] drm/i915: mask tiled bit when updating ILK sprites Ander Conselvan de Oliveira
2012-07-13 13:26 ` Chris Wilson
2012-07-13 15:06 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox