From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: don't forget the PCH backlight registers
Date: Sat, 14 Jul 2012 18:15:31 +0200 [thread overview]
Message-ID: <20120714161531.GD5498@phenom.ffwll.local> (raw)
In-Reply-To: <1342277833-3694-1-git-send-email-przanoni@gmail.com>
On Sat, Jul 14, 2012 at 11:57:12AM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> When we enable/disable the CPU backlight registers we can't forget to
> enable/disable the PCH backlight registers. Since we're using the CPU
> registers we should also unset the override bit.
>
> Fixes a regression on the following commit:
> drm/i915: properly enable the blc controller on the right pipe
>
> The commit just deleted the code that sets the PCH registers, so it
> was relying on the values set by the BIOS. I told my BIOS to boot on
> the DVI monitor instead of the LVDS panel, so I noticed the bug.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Ok, I've double-check bspec, and at least on ilk, snb & ivb this seems to
be a sane thing to do. Patch queued for -next, thanks.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-07-14 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 14:57 [PATCH] drm/i915: don't forget the PCH backlight registers Paulo Zanoni
2012-07-14 16:15 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120714161531.GD5498@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox