From: Olivier Galibert <galibert@pobox.com>
To: Paul Berry <stereotype441@gmail.com>
Cc: mesa-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 1/5] intel gen4/5: fix GL_VERTEX_PROGRAM_TWO_SIDE.
Date: Tue, 17 Jul 2012 10:57:57 +0200 [thread overview]
Message-ID: <20120717085757.GB360@dspnet.fr> (raw)
In-Reply-To: <CA+yLL64x0p7ggxpyAbw=8Uy6ccKzmoO2p77cJ-e+5G7K_ED7bA@mail.gmail.com>
On Mon, Jul 16, 2012 at 08:43:17PM -0700, Paul Berry wrote:
> Also, I'm not convinced that #3 is necessary. Is there something in the
> spec that dictates this behaviour? My reading of the spec is that if the
> vertex shader writes to gl_BackColor but not glFrontColor, then the
> contents of gl_Color in the fragment shader is undefined.
Oh, I remember why I did that in the first place. All the front/back
piglit tests only write the appropriate color slot and not the other
one.
The language is annoying:
The following built-in vertex output variables are available, but deprecated. A particular one should be
written to if any functionality in a corresponding fragment shader or fixed pipeline uses it or state derived
from it. Otherwise, behavior is undefined.
out vec4 gl_FrontColor;
out vec4 gl_BackColor;
out vec4 gl_FrontSecondaryColor;
out vec4 gl_BackSecondaryColor;
[...]
One could argue that you don't "use" gl_FrontColor if all your
polygons are back-facing. Dunno. Do you consider all of the twoside
piglit tests buggy? We can fix *that*.
OG.
next prev parent reply other threads:[~2012-07-17 8:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 18:50 [PATCH 0/5] First batch of gm45 clipping/interpolation fixes Olivier Galibert
2012-06-30 18:50 ` [PATCH 1/5] intel gen4/5: fix GL_VERTEX_PROGRAM_TWO_SIDE Olivier Galibert
2012-07-17 3:43 ` [Mesa-dev] " Paul Berry
2012-07-17 8:33 ` [Intel-gfx] " Olivier Galibert
2012-07-17 8:57 ` Olivier Galibert [this message]
2012-07-17 14:37 ` Paul Berry
2012-07-29 17:00 ` [Mesa-dev] " Olivier Galibert
2012-07-30 17:30 ` [Intel-gfx] " Eric Anholt
2012-07-30 19:55 ` [Mesa-dev] " Olivier Galibert
2012-07-31 15:28 ` [Intel-gfx] " Eric Anholt
2012-06-30 18:50 ` [PATCH 2/5] intel gen4-5: Compute the interpolation status for every variable in one place Olivier Galibert
2012-07-17 4:24 ` Paul Berry
2012-06-30 18:50 ` [PATCH 3/5] intel gen4-5: Correctly setup the parameters in the sf Olivier Galibert
2012-07-17 12:50 ` [Mesa-dev] " Paul Berry
2012-07-17 13:07 ` Paul Berry
2012-06-30 18:50 ` [PATCH 4/5] intel gen4-5: Correctly handle flat vs. non-flat in the clipper Olivier Galibert
2012-07-17 12:55 ` [Mesa-dev] " Paul Berry
2012-06-30 18:50 ` [PATCH 5/5] intel gen4-5: Make noperspective clipping work Olivier Galibert
2012-07-17 14:07 ` [Mesa-dev] " Paul Berry
2012-07-13 7:20 ` [Mesa-dev] [PATCH 0/5] First batch of gm45 clipping/interpolation fixes Olivier Galibert
2012-07-13 21:45 ` Kenneth Graunke
2012-07-14 9:21 ` Olivier Galibert
2012-07-17 2:33 ` Paul Berry
2012-07-17 14:42 ` [Intel-gfx] " Paul Berry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717085757.GB360@dspnet.fr \
--to=galibert@pobox.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mesa-dev@lists.freedesktop.org \
--cc=stereotype441@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox