From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't hardcode the number of pipes in the error state dump
Date: Thu, 16 Aug 2012 00:40:13 +0200 [thread overview]
Message-ID: <20120815224013.GD5533@phenom.ffwll.local> (raw)
In-Reply-To: <1345056147_100284@CP5-2952>
On Wed, Aug 15, 2012 at 07:42:15PM +0100, Chris Wilson wrote:
> On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau <damien.lespiau@gmail.com> wrote:
> > From: Damien Lespiau <damien.lespiau@intel.com>
> >
> > New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> > for_each_pipe() macro and make struct intel_display_error_state is big
> > enough.
> >
> > V2: Also add the number of pipes emitted (Chris Wilson)
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
> I guess next on your list will be adding some of the PCH register
> states, along with a list of active encoders / connectors etc.
I'm not sure that's worth it, at least usually the gt doesn't fall over
when we anger the pch ... Simply grabbing a register dump for interesting
configurations and comparing them worksforme.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-08-15 22:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 18:23 [PATCH] drm/i915: Don't hardcode the number of pipes in the error state dump Damien Lespiau
2012-08-15 18:42 ` Chris Wilson
2012-08-15 22:40 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-15 16:57 Damien Lespiau
2012-08-15 17:00 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815224013.GD5533@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox