From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915/contexts: fix list corruption
Date: Thu, 16 Aug 2012 00:50:55 +0200 [thread overview]
Message-ID: <20120815225055.GH5533@phenom.ffwll.local> (raw)
In-Reply-To: <1344980117-1993-3-git-send-email-ben@bwidawsk.net>
On Tue, Aug 14, 2012 at 02:35:14PM -0700, Ben Widawsky wrote:
> After reset we unconditionally reinitialize lists. If the context switch
> hasn't yet completed before the suspend, the default context object will
> end up on lists that are going to go away when we resume.
>
> The patch forces the context switch to be synchronous before suspend
> assuring that the active/inactive tracking is correct at the time of
> resume.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=52429
> Tested-by: Guang A Yang <guang.a.yang@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Picked up for -fixes (with a minor conflict resolved), thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-08-15 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 21:35 [PATCH 0/5] Some HW context fixes Ben Widawsky
2012-08-14 21:35 ` [PATCH 1/5] drm/i915: Cleanup instdone state Ben Widawsky
2012-08-15 9:14 ` Chris Wilson
2012-08-15 17:43 ` Ben Widawsky
2012-08-14 21:35 ` [PATCH 2/5] drm/i915/contexts: fix list corruption Ben Widawsky
2012-08-15 22:50 ` Daniel Vetter [this message]
2012-08-14 21:35 ` [PATCH 3/5] drm/i915/contexts: Switch to default on resume Ben Widawsky
2012-08-15 9:18 ` Chris Wilson
2012-08-15 15:58 ` Ben Widawsky
2012-08-14 21:35 ` [PATCH 4/5] drm/i915/contexts: Add forced switches Ben Widawsky
2012-08-14 21:35 ` [PATCH 5/5] drm/i915/contexts: Serialize default context init Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815225055.GH5533@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox