From: Daniel Vetter <daniel@ffwll.ch>
To: Simon Farnsworth <simon.farnsworth@onelan.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix sdvo hotplug support check and activation
Date: Mon, 3 Sep 2012 09:38:50 +0200 [thread overview]
Message-ID: <20120903073849.GD5225@phenom.ffwll.local> (raw)
In-Reply-To: <3793539.KImO5gFPQT@f17simon>
On Wed, Aug 29, 2012 at 03:12:37PM +0100, Simon Farnsworth wrote:
> On Wednesday 29 August 2012 16:43:58 Jani Nikula wrote:
> > The sdvo hotplug support check and activation has worked by coincidence for
> > TMDS0. The boolean value returned by intel_sdvo_supports_hotplug() was
> > masked with a bit shifted by device number, which also should have been one
> > of SDVO_OUTPUT_* bits instead. Boolean true masked with 1 shifted by 0 just
> > happened to match SDVO_OUTPUT_TMDS0...
> >
> > Get hotplug support as a bit mask, check the correct bits for support, and
> > use the correct bits for activating hotplug support.
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> Reviewed-by: Simon Farnsworth <simon.farnsworth@onelan.com>
Queued for -next (together with a duplicate of the bugfix to avoid merge
hassles), thanks for the patch.
-Daniel
>
> The code you're fixing was written with the aid of ajax's educated guesses -
> it's nice to see an Intel employee fix it to match the spec.
> --
> Simon Farnsworth
> Software Engineer
> ONELAN Ltd
> http://www.onelan.com
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-09-03 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 9:43 [PATCH] drm/i915: only enable sdvo hotplug irq if needed Jani Nikula
2012-08-29 11:08 ` [PATCH v2] " Jani Nikula
2012-08-29 13:43 ` [PATCH] drm/i915: fix sdvo hotplug support check and activation Jani Nikula
2012-08-29 15:55 ` Simon Farnsworth
[not found] ` <3793539.KImO5gFPQT@f17simon>
2012-09-03 7:38 ` Daniel Vetter [this message]
2012-09-03 7:44 ` [PATCH v2] drm/i915: only enable sdvo hotplug irq if needed Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903073849.GD5225@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=simon.farnsworth@onelan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox