From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915: fix sdvo hotplug support check and activation
Date: Wed, 29 Aug 2012 16:55:12 +0100 [thread overview]
Message-ID: <5472959.9uvtq7SlKM@f17simon> (raw)
In-Reply-To: <1346247838-6331-1-git-send-email-jani.nikula@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 986 bytes --]
(apologies to Daniel and Jani, who've seen this twice - I accidentally
sent it from the wrong address originally).
On Wednesday 29 August 2012 16:43:58 Jani Nikula wrote:
> The sdvo hotplug support check and activation has worked by coincidence for
> TMDS0. The boolean value returned by intel_sdvo_supports_hotplug() was
> masked with a bit shifted by device number, which also should have been one
> of SDVO_OUTPUT_* bits instead. Boolean true masked with 1 shifted by 0 just
> happened to match SDVO_OUTPUT_TMDS0...
>
> Get hotplug support as a bit mask, check the correct bits for support, and
> use the correct bits for activating hotplug support.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
Reviewed-by: Simon Farnsworth <simon.farnsworth@onelan.com>
The code you're fixing was written with the aid of ajax's educated guesses -
it's nice to see an Intel employee fix it to match the spec.
--
Simon Farnsworth
Software Engineer
ONELAN Ltd
http://www.onelan.com
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-08-29 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 9:43 [PATCH] drm/i915: only enable sdvo hotplug irq if needed Jani Nikula
2012-08-29 11:08 ` [PATCH v2] " Jani Nikula
2012-08-29 13:43 ` [PATCH] drm/i915: fix sdvo hotplug support check and activation Jani Nikula
2012-08-29 15:55 ` Simon Farnsworth [this message]
[not found] ` <3793539.KImO5gFPQT@f17simon>
2012-09-03 7:38 ` Daniel Vetter
2012-09-03 7:44 ` [PATCH v2] drm/i915: only enable sdvo hotplug irq if needed Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5472959.9uvtq7SlKM@f17simon \
--to=simon.farnsworth@onelan.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox