From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/7] drm/i915: Error checks in gen6_set_rps
Date: Wed, 12 Sep 2012 23:37:44 +0200 [thread overview]
Message-ID: <20120912213744.GT5533@phenom.ffwll.local> (raw)
In-Reply-To: <275ffc$6hj53c@fmsmga002.fm.intel.com>
On Sun, Sep 09, 2012 at 07:25:40PM +0100, Chris Wilson wrote:
> On Fri, 7 Sep 2012 19:43:42 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > With the new "standardized" sysfs interfaces we need to be a bit more
> > careful about setting the RPS values.
> >
> > Because the sysfs code and the rps workqueue can run at the same time,
> > if the sysfs setter wins the race to the mutex, the workqueue can come
> > in and set a value which is out of range (ie. we're no longer protecting
> > by RPINTLIM).
> >
> > I was not able to actually make this error occur in testing.
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> Good catch, care to squeeze the comment into a single line ;-)
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Applied all patches to dinq up to this one here, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-09-12 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 2:43 [PATCH 0/8 v2] Moar sysfs stuff Ben Widawsky
2012-09-08 2:43 ` [REPOST PATCH 1/7] drm/i915: variable renames Ben Widawsky
2012-09-08 2:43 ` [REPOST PATCH 2/7] drm/i915: #define gpu freq multipler Ben Widawsky
2012-09-08 2:43 ` [REPOST PATCH 3/7 v2] drm/i915: Add current/max/min GPU freq to sysfs Ben Widawsky
2012-09-08 2:43 ` [PATCH 4/7] drm/i915: POSTING_READ the new rps value Ben Widawsky
2012-09-09 18:26 ` Chris Wilson
2012-09-08 2:43 ` [PATCH 5/7] drm/i915: Error checks in gen6_set_rps Ben Widawsky
2012-09-09 18:25 ` Chris Wilson
2012-09-12 21:37 ` Daniel Vetter [this message]
2012-09-08 2:43 ` [PATCH 6/7 v3] drm/i915: Add setters for min/max frequency Ben Widawsky
2012-09-12 14:46 ` Daniel Vetter
2012-09-13 1:12 ` [PATCH 6/7 v4] " Ben Widawsky
2012-09-08 2:43 ` [REPOST PATCH 7/7] drm/i915: Show render P state thresholds in sysfs Ben Widawsky
2012-09-14 16:51 ` Daniel Vetter
2012-09-08 2:43 ` [PATCH] sysfs rps test added Ben Widawsky
2012-09-14 18:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912213744.GT5533@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox