From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/5] drm/i915: disable the cpu edp port after the cpu pipe
Date: Thu, 13 Sep 2012 23:12:47 +0200 [thread overview]
Message-ID: <20120913211247.GH5693@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGSSkRMmiMG9fF3p94ADeB58hfhEbu51hJP_NS0GP6-sFg@mail.gmail.com>
On Thu, Sep 13, 2012 at 04:43:57PM -0300, Paulo Zanoni wrote:
> 2012/9/13 Daniel Vetter <daniel@ffwll.ch>:
> > On Thu, Sep 13, 2012 at 04:11:20PM -0300, Paulo Zanoni wrote:
> >> Hi
> >>
> >> 2012/9/6 Daniel Vetter <daniel.vetter@ffwll.ch>:
> >> > See bspec, Vol3 Part2, Section 1.1.3 "Display Mode Set Sequence". This
> >> > applies to all platforms where we currently support eDP on, i.e. ilk,
> >> > snb & ivb.
> >> >
> >>
> >> Ok, so I looked at BSpec and the conclusion is: shouldn't we do this
> >> for eDP _and_ DP instead of just eDP? The only things to disable
> >> before the crtc are audio, the panel backlight, and then the panel
> >> power.
> >>
> >> Your patch looks correct, but maybe it could be even more correct by
> >> including DP too? Yes, I can help testing.
> >
> > The dp pll for cpu edp is special, since we set it in the DP_A register.
> > The pll for pch dp ports is just the regular pch pll iirc, and that is
> > handled by the common code. Also, dp pch seems to wfm, whereas cpu edp was
> > definitely broken.
> >
> > In any case, frobbing the pch dp sequence would be a separate patch imo.
> > So can I still have an r-b for this on here?
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
I've slurped in the other 3 patches, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-09-13 21:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 20:15 [PATCH 0/5] cpu edp fixes Daniel Vetter
2012-09-06 20:15 ` [PATCH 1/5] drm/i915: add encoder->pre_enable/post_disable Daniel Vetter
2012-09-12 13:48 ` Paulo Zanoni
2012-09-06 20:15 ` [PATCH 2/5] drm/i915: clean up the cpu edp pll special case Daniel Vetter
2012-09-12 21:00 ` Paulo Zanoni
2012-09-13 15:23 ` Daniel Vetter
2012-09-06 20:15 ` [PATCH 3/5] drm/i915: robustify edp_pll_on/off Daniel Vetter
2012-09-13 17:46 ` Paulo Zanoni
2012-09-13 19:22 ` Daniel Vetter
2012-09-13 19:27 ` Daniel Vetter
2012-09-06 20:15 ` [PATCH 4/5] drm/i915: rip out dp port enabling cludges^Wchecks Daniel Vetter
2012-09-13 18:27 ` Paulo Zanoni
2012-09-06 20:15 ` [PATCH 5/5] drm/i915: disable the cpu edp port after the cpu pipe Daniel Vetter
2012-09-13 19:11 ` Paulo Zanoni
2012-09-13 19:17 ` Daniel Vetter
2012-09-13 19:43 ` Paulo Zanoni
2012-09-13 21:12 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913211247.GH5693@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox