From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, mika.kuoppala@intel.com
Subject: Re: [PATCH v2 1/2] drm/i915: EBUSY status handling added to i915_gem_fault().
Date: Wed, 3 Oct 2012 16:30:52 +0200 [thread overview]
Message-ID: <20121003143052.GG5329@phenom.ffwll.local> (raw)
In-Reply-To: <051c15$4gt4qo@AZSMGA002.ch.intel.com>
On Wed, Oct 03, 2012 at 03:27:36PM +0100, Chris Wilson wrote:
> On Wed, 3 Oct 2012 17:15:26 +0300, mika.kuoppala@intel.com wrote:
> > From: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> >
> > Subsequent threads returning EBUSY from vm_insert_pfn() was not handled
> > correctly. As a result concurrent access from new threads to
> > mmapped data caused SIGBUS.
> >
> > Tested-by: Mika Kuoppala <mika.kuoppala@intel.com>
> > Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
>
> Fixes? Reported-by?
>
> I would order the case slightly different so that the comment block
> comes after EIO.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
I've added the fixes note and applied both patches to -fixes. Thanks for
the patch & review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-10-03 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 13:27 [PATCH 1/3] drm/i915: EBUSY status handling added to i915_gem_fault() mika.kuoppala
2012-10-03 13:27 ` [PATCH 2/3] drm/i915: print kernel warning if vmi915_gem_fault returns with error mika.kuoppala
2012-10-03 13:27 ` [PATCH 3/3] Documentation: kernel-parameters.txt Add drm_kms_helper.poll mika.kuoppala
2012-10-03 14:15 ` [PATCH v2 1/2] drm/i915: EBUSY status handling added to i915_gem_fault() mika.kuoppala
2012-10-03 14:15 ` [PATCH v2 2/2] drm/i915: print warning if vmi915_gem_fault error is not handled mika.kuoppala
2012-10-03 14:25 ` Chris Wilson
2012-10-03 14:27 ` [PATCH v2 1/2] drm/i915: EBUSY status handling added to i915_gem_fault() Chris Wilson
2012-10-03 14:30 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003143052.GG5329@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox