From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: flush system agent TLBs on SNB so we can WC map the PTEs
Date: Fri, 12 Oct 2012 10:18:09 +0200 [thread overview]
Message-ID: <20121012081809.GA5155@phenom.ffwll.local> (raw)
In-Reply-To: <CAPM=9tx-bMuyKJ-DZcX-A0Rxax8eD0ivJnmhCy6NOe9Gnshh+A@mail.gmail.com>
On Fri, Oct 12, 2012 at 03:54:50AM -0400, Dave Airlie wrote:
> On Thu, Oct 11, 2012 at 7:54 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Thu, 11 Oct 2012 20:29:47 -0300
> > Paulo Zanoni <przanoni@gmail.com> wrote:
> >
> >> Hi
> >>
> >> 2012/10/11 Jesse Barnes <jbarnes@virtuousgeek.org>:
> >> > I've only lightly tested this so far, but the corruption seems to be
> >> > gone if I write the GFX_FLSH_CNTL reg after binding an object. This
> >> > register should control the TLB for the system agent, which is what CPU
> >> > mapped objects will go through.
> >> >
> >> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >>
> >> I'm not sure if this is the patch you asked me to test on IRC, but,
> >> well this is the patch I tested :)
> >>
> >> I tested it on HSW on top of dinq + some other patches. Booted the
> >> machine, ran mostly xfterm4 under Xfce, but I also ran firefox,
> >> gnome-shell and restarted X a few times. No GPU hangs so far. I'm
> >> testing this for about 3-4 hours.
> >>
> >> I do have to say that I could not find this register on the HSW
> >> documentation, but I also did no see any "Unclaimed write" messages
> >> containing the 101008 address... I'm a little confused.
> >>
> >> And the interesting thing: intel_gpu_tools is useless now. I keep
> >> getting "Couldn't map MMIO region: Resource temporarily unavailable".
> >> Do you see this too?
> >
> > No I haven't seen that, I ran some tests today with the tip of the tree
> > too... Dunno why the resource files would return EBUSY? Maybe because
> > a driver is bound?
>
> More likely because of some WB/WC/UC collision. We don't like aliases.
Yep, you need to upgrade, latest i-g-t should handle the wc/uc split
correctly. The important testcase is gem_gtt_cpu_tlb, if that one works
this patch is good.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-12 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 17:32 [PATCH] drm/i915: flush system agent TLBs on SNB so we can WC map the PTEs Jesse Barnes
2012-10-11 23:29 ` Paulo Zanoni
2012-10-11 23:54 ` Jesse Barnes
2012-10-12 7:54 ` Dave Airlie
2012-10-12 8:18 ` Daniel Vetter [this message]
2012-10-12 17:21 ` Paulo Zanoni
2012-10-16 19:11 ` Paulo Zanoni
2012-10-16 19:50 ` Daniel Vetter
2012-10-22 12:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012081809.GA5155@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox