From: Daniel Vetter <daniel@ffwll.ch>
To: Egbert Eich <eich@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] DRM/i915: Don't delete DPLL Multiplier during DAC init.
Date: Tue, 16 Oct 2012 09:33:51 +0200 [thread overview]
Message-ID: <20121016073351.GF5753@phenom.ffwll.local> (raw)
In-Reply-To: <1350225191-8444-1-git-send-email-eich@suse.de>
On Sun, Oct 14, 2012 at 04:33:11PM +0200, Egbert Eich wrote:
> The DPLL multipiler is set up in intel_display.c:i9xx_update_pll()
> called from i9xx_crtc_mode_set().
> There the DPLL multiplier is adjusted so that the SDVO gets a sufficient
> bus clock.
> When cloning a CRTC between an SDVO driven encoder and the standard
> DAC the DAC setup code reseted the multiplier value to 1 thus undoing
> the correct setup. There is no need to touch the multiplier in the DAC
> setup code: the correct value (i.e. 1 in case no SDVO encoder is used)
> is set by i9xx_update_pll() already.
> A comment at the code suggested that this code is a left over from the
> days when there was no setup for clone modes.
>
> Signed-off-by: Egbert Eich <eich@suse.de>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-10-16 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 14:33 [PATCH] DRM/i915: Don't delete DPLL Multiplier during DAC init Egbert Eich
2012-10-16 7:33 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016073351.GF5753@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=eich@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox