From: Daniel Vetter <daniel@ffwll.ch>
To: Egbert Eich <eich@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] DRM/i915: Restore sdvo_flags after dtd->mode->dtd Roundrtrip.
Date: Tue, 16 Oct 2012 09:48:04 +0200 [thread overview]
Message-ID: <20121016074804.GI5753@phenom.ffwll.local> (raw)
In-Reply-To: <1350131371-1268-1-git-send-email-eich@suse.de>
On Sat, Oct 13, 2012 at 02:29:31PM +0200, Egbert Eich wrote:
> For TV and LVDS encoders intel_sdvo_set_input_timings_for_mode()
> is called to pass a mode to the sdvo chip and retrieve a dtd
> containing information needed to calculate the adjusted_mode which
> is done by intel_sdvo_get_dtd_from_mode().
> To set this adjusted_mode as input mode for the sdvo chip, a dtd is
> recalculated using intel_sdvo_get_mode_from_dtd(). During this round
> trip the sdvo_flags contained in the dtd obtained from the hardware
> are lost.
> Since these flags cannot be ignored in all cases this patch preserves
> and restores them.
>
> This regression has been introduced in
>
> commit 6651819b4b4fc3caa6964c5d825eb4bb996f3905
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Sun Apr 1 19:16:18 2012 +0200
>
> drm/i915: handle input/output sdvo timings separately in mode_set
>
> Signed-off-by: Egbert Eich <eich@suse.de>
Long term we need to decently improve our adjusted_mode handling and stop
shoveling random state into random structures. Short-term this looks good
enough. Thanks for the patch, applied.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-10-16 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 12:29 [PATCH] DRM/i915: Restore sdvo_flags after dtd->mode->dtd Roundrtrip Egbert Eich
2012-10-16 7:48 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016074804.GI5753@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=eich@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox