* [PATCH] drm/i915: shut up spurious WARN in the gtt fault handler
@ 2012-10-17 9:17 Daniel Vetter
2012-10-17 9:43 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2012-10-17 9:17 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
-ENOSPC can happen if userspace is being simplistic and tries to map a
too big object. To aid further spurious WARN debugging, also print out
the error code.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56017
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_gem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index bb941f8..45888d2 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1408,8 +1408,10 @@ out:
return VM_FAULT_NOPAGE;
case -ENOMEM:
return VM_FAULT_OOM;
+ case -ENOSPC:
+ return VM_FAULT_SIGBUS;
default:
- WARN_ON_ONCE(ret);
+ WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret);
return VM_FAULT_SIGBUS;
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: shut up spurious WARN in the gtt fault handler
2012-10-17 9:17 [PATCH] drm/i915: shut up spurious WARN in the gtt fault handler Daniel Vetter
@ 2012-10-17 9:43 ` Chris Wilson
2012-10-17 9:57 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-10-17 9:43 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
On Wed, 17 Oct 2012 11:17:16 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> -ENOSPC can happen if userspace is being simplistic and tries to map a
> too big object. To aid further spurious WARN debugging, also print out
> the error code.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56017
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
%i is the new %d?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: shut up spurious WARN in the gtt fault handler
2012-10-17 9:43 ` Chris Wilson
@ 2012-10-17 9:57 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-10-17 9:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, Intel Graphics Development
On Wed, Oct 17, 2012 at 10:43:15AM +0100, Chris Wilson wrote:
> On Wed, 17 Oct 2012 11:17:16 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > -ENOSPC can happen if userspace is being simplistic and tries to map a
> > too big object. To aid further spurious WARN debugging, also print out
> > the error code.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56017
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> %i is the new %d?
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Picked up for -fixes.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-17 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-17 9:17 [PATCH] drm/i915: shut up spurious WARN in the gtt fault handler Daniel Vetter
2012-10-17 9:43 ` Chris Wilson
2012-10-17 9:57 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox