* [PATCH] drm/i915: VLV does not have a sprite scaler
@ 2012-10-25 17:06 Damien Lespiau
2012-10-26 16:25 ` Jesse Barnes
0 siblings, 1 reply; 4+ messages in thread
From: Damien Lespiau @ 2012-10-25 17:06 UTC (permalink / raw)
To: intel-gfx
From: Damien Lespiau <damien.lespiau@intel.com>
Just like HSW, VLV does not have a sprite scale. Set
intel_plane->can_scale accordingly.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/i915/intel_sprite.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 24b8231..9c378f5 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -700,7 +700,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe)
break;
case 7:
- if (IS_HASWELL(dev))
+ if (IS_HASWELL(dev) || IS_VALLEYVIEW(dev))
intel_plane->can_scale = false;
else
intel_plane->can_scale = true;
--
1.7.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: VLV does not have a sprite scaler
2012-10-25 17:06 [PATCH] drm/i915: VLV does not have a sprite scaler Damien Lespiau
@ 2012-10-26 16:25 ` Jesse Barnes
2012-10-26 16:36 ` Jesse Barnes
2012-10-26 16:39 ` Daniel Vetter
0 siblings, 2 replies; 4+ messages in thread
From: Jesse Barnes @ 2012-10-26 16:25 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
On Thu, 25 Oct 2012 18:06:19 +0100
Damien Lespiau <damien.lespiau@gmail.com> wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
>
> Just like HSW, VLV does not have a sprite scale. Set
> intel_plane->can_scale accordingly.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_sprite.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 24b8231..9c378f5 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -700,7 +700,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe)
> break;
>
> case 7:
> - if (IS_HASWELL(dev))
> + if (IS_HASWELL(dev) || IS_VALLEYVIEW(dev))
> intel_plane->can_scale = false;
> else
> intel_plane->can_scale = true;
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
We could also set it to true if the gen >= 7 and leave it as false
otherwise. Either way though is fine.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: VLV does not have a sprite scaler
2012-10-26 16:25 ` Jesse Barnes
@ 2012-10-26 16:36 ` Jesse Barnes
2012-10-26 16:39 ` Daniel Vetter
1 sibling, 0 replies; 4+ messages in thread
From: Jesse Barnes @ 2012-10-26 16:36 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Fri, 26 Oct 2012 09:25:21 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 25 Oct 2012 18:06:19 +0100
> Damien Lespiau <damien.lespiau@gmail.com> wrote:
>
> > From: Damien Lespiau <damien.lespiau@intel.com>
> >
> > Just like HSW, VLV does not have a sprite scale. Set
> > intel_plane->can_scale accordingly.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index 24b8231..9c378f5 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -700,7 +700,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe)
> > break;
> >
> > case 7:
> > - if (IS_HASWELL(dev))
> > + if (IS_HASWELL(dev) || IS_VALLEYVIEW(dev))
> > intel_plane->can_scale = false;
> > else
> > intel_plane->can_scale = true;
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> We could also set it to true if the gen >= 7 and leave it as false
> otherwise. Either way though is fine.
>
Nevermind. Was trying to catch future platforms here, but both VLV and
HSW are listed as gen 7 so we can't do it that way...
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: VLV does not have a sprite scaler
2012-10-26 16:25 ` Jesse Barnes
2012-10-26 16:36 ` Jesse Barnes
@ 2012-10-26 16:39 ` Daniel Vetter
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2012-10-26 16:39 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Fri, Oct 26, 2012 at 09:25:21AM -0700, Jesse Barnes wrote:
> On Thu, 25 Oct 2012 18:06:19 +0100
> Damien Lespiau <damien.lespiau@gmail.com> wrote:
>
> > From: Damien Lespiau <damien.lespiau@intel.com>
> >
> > Just like HSW, VLV does not have a sprite scale. Set
> > intel_plane->can_scale accordingly.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index 24b8231..9c378f5 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -700,7 +700,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe)
> > break;
> >
> > case 7:
> > - if (IS_HASWELL(dev))
> > + if (IS_HASWELL(dev) || IS_VALLEYVIEW(dev))
> > intel_plane->can_scale = false;
> > else
> > intel_plane->can_scale = true;
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> We could also set it to true if the gen >= 7 and leave it as false
> otherwise. Either way though is fine.
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-26 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 17:06 [PATCH] drm/i915: VLV does not have a sprite scaler Damien Lespiau
2012-10-26 16:25 ` Jesse Barnes
2012-10-26 16:36 ` Jesse Barnes
2012-10-26 16:39 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox