From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Kill i915_gem_execbuffer_wait_for_flips()
Date: Wed, 31 Oct 2012 21:17:27 +0200 [thread overview]
Message-ID: <20121031191726.GK3791@intel.com> (raw)
In-Reply-To: <1351705121-17627-2-git-send-email-ville.syrjala@linux.intel.com>
On Wed, Oct 31, 2012 at 07:38:40PM +0200, ville.syrjala@linux.intel.com wrote:
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index cbc0035..83e16f8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2177,8 +2177,7 @@ intel_finish_fb(struct drm_framebuffer *old_fb)
> int ret;
>
> wait_event(dev_priv->pending_flip_queue,
> - atomic_read(&dev_priv->mm.wedged) ||
> - atomic_read(&obj->pending_flip) == 0);
> + atomic_read(&dev_priv->mm.wedged));
And of course this bit is total nonsense now. I had the logic inverted
in my mind. So this guy actually wants to stop waiting when the GPU
hangs, not the other way around. So I need to drop the whole
wait_event() here.
Stand by for v2...
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2012-10-31 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 17:38 [PATCH 0/2] drm/i915: Page flip stuff ville.syrjala
2012-10-31 17:38 ` [PATCH 1/2] drm/i915: Kill i915_gem_execbuffer_wait_for_flips() ville.syrjala
2012-10-31 19:17 ` Ville Syrjälä [this message]
2012-11-01 0:18 ` Eric Anholt
2012-11-01 8:58 ` Chris Wilson
2012-10-31 17:38 ` [PATCH 2/2] drm/i915: Wait for pending flips in intel_pipe_set_base() ville.syrjala
2012-10-31 17:43 ` Chris Wilson
2012-10-31 18:17 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031191726.GK3791@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox