From: Chris Wilson <chris@chris-wilson.co.uk>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Wait for pending flips in intel_pipe_set_base()
Date: Wed, 31 Oct 2012 17:43:16 +0000 [thread overview]
Message-ID: <eeac1e$4rdcup@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1351705121-17627-3-git-send-email-ville.syrjala@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Wed, 31 Oct 2012 19:38:41 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_pipe_set_base() never actually waited for any pending page flips
> on the CRTC. It looks like it tried to, by calling intel_finish_fb() on
> the current front buffer. But the pending flips were actually tracked
> in the BO of the previous front buffer, so the call to intel_finish_fb()
> never did anything useful.
>
> Now even the pending_flip counter is gone, so we should just
> use intel_crtc_wait_for_pending_flips(), but since we're already holding
> struct_mutex when we would call that function, we need another version
> of it, that itself doesn't lock struct_mutex.
That function call is now superfluous as you pointed out in an earlier
review...
But yes, not waking up the pending_flip_queue after a GPU hang is a
recent bug, and could explain the lockup in
https://bugs.freedesktop.org/show_bug.cgi?id=56337.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-10-31 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 17:38 [PATCH 0/2] drm/i915: Page flip stuff ville.syrjala
2012-10-31 17:38 ` [PATCH 1/2] drm/i915: Kill i915_gem_execbuffer_wait_for_flips() ville.syrjala
2012-10-31 19:17 ` Ville Syrjälä
2012-11-01 0:18 ` Eric Anholt
2012-11-01 8:58 ` Chris Wilson
2012-10-31 17:38 ` [PATCH 2/2] drm/i915: Wait for pending flips in intel_pipe_set_base() ville.syrjala
2012-10-31 17:43 ` Chris Wilson [this message]
2012-10-31 18:17 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eeac1e$4rdcup@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox