* [PATCH] drm/i915/crt: fix DPMS standby and suspend mode handling
@ 2012-11-05 11:51 Jani Nikula
2012-11-06 9:50 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2012-11-05 11:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
PCH platforms and VLV should map DPMS standby and suspend modes to off, but
due to a buggy reversed comparison this is done on pre-PCH platforms
instead.
Reported-by: Loïc Yhuel <loic.yhuel@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56754
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_crt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 1c97c27..4cbb9ab 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -143,7 +143,7 @@ static void intel_crt_dpms(struct drm_connector *connector, int mode)
int old_dpms;
/* PCH platforms and VLV only support on/off. */
- if (INTEL_INFO(dev)->gen < 5 && mode != DRM_MODE_DPMS_ON)
+ if (INTEL_INFO(dev)->gen >= 5 && mode != DRM_MODE_DPMS_ON)
mode = DRM_MODE_DPMS_OFF;
if (mode == connector->dpms)
--
1.7.9.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915/crt: fix DPMS standby and suspend mode handling
2012-11-05 11:51 [PATCH] drm/i915/crt: fix DPMS standby and suspend mode handling Jani Nikula
@ 2012-11-06 9:50 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2012-11-06 9:50 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, Nov 05, 2012 at 01:51:51PM +0200, Jani Nikula wrote:
> PCH platforms and VLV should map DPMS standby and suspend modes to off, but
> due to a buggy reversed comparison this is done on pre-PCH platforms
> instead.
>
> Reported-by: Loïc Yhuel <loic.yhuel@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56754
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-06 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-05 11:51 [PATCH] drm/i915/crt: fix DPMS standby and suspend mode handling Jani Nikula
2012-11-06 9:50 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox