public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Richard Yao <ryao@gentoo.org>
Cc: gentoo-bsd@lists.gentoo.org, intel-gfx@lists.freedesktop.org,
	x11@freebsd.org, David Shao <davshao@gmail.com>
Subject: Re: [PATCH] intel: Fix missing ETIME on BSD operating systems
Date: Sun, 11 Nov 2012 09:26:19 -0800	[thread overview]
Message-ID: <20121111092619.00004321@unknown> (raw)
In-Reply-To: <509EC8DA.4050205@gentoo.org>

On Sat, 10 Nov 2012 16:36:26 -0500
Richard Yao <ryao@gentoo.org> wrote:

> On 11/10/2012 03:12 PM, Eric Anholt wrote:
> > Richard Yao <ryao@cs.stonybrook.edu> writes:
> > 
> >> From: David Shao <davshao@gmail.com>
> >>
> >> Originally posted to Free Desktop bug #52549 by David Shao.
> >> Resolves Gentoo Bug #433403.
> >> Commit message by Richard Yao.
> > 
> > Are you really unable to get the same errnos in your port of the
> > kernel modules?  Having mismatched errno returns from upstream is a
> > great way to have obscure bugs on your port, given that our kernel
> > guys like to look for alternative errnos to be able to distinguish
> > failure modes from userland.
> > 
> > I don't like the idea of this patch landing.
> 
> I have added the FreeBSD x11 team alias to CC, which I probably should
> have done in my original email. They are in a better position to
> answer this than I am.
> 
> At present, MySQL also does this. Changing that would require changes
> to the userland of FreeBSD (and other BSDs). The FreeBSD x11 team is
> in a position to do that. I am in the process of getting Gentoo's X11
> stack working on Gentoo FreeBSD, so I am interested in their answer
> to your question as well.
> 
> 

Before pushing the patch, I did a bit of googling and I too found that
MySQL and LibreOffice does this, so it seemed okay to me. It's not
terribly prolific because I think many cross-platform products do not
use interfaces which return ETIME.

It sounds like BSD though is the only remaining holdout, as Windows and
OSX both seem to support ETIME.

  reply	other threads:[~2012-11-11 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-10  5:24 [PATCH] intel: Fix missing ETIME on BSD operating systems Richard Yao
2012-11-10 20:01 ` Ben Widawsky
2012-11-10 20:12 ` Eric Anholt
2012-11-10 21:36   ` Richard Yao
2012-11-11 17:26     ` Ben Widawsky [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-10  5:23 Richard Yao
2012-11-10  5:06 Richard Yao
2012-11-09 22:06 Richard Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121111092619.00004321@unknown \
    --to=ben@bwidawsk.net \
    --cc=davshao@gmail.com \
    --cc=gentoo-bsd@lists.gentoo.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ryao@gentoo.org \
    --cc=x11@freebsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox