From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, Daniel J Blueman <daniel@quora.org>
Subject: Re: [PATCH] drm/i915: Use LRI to update the semaphore registers
Date: Tue, 20 Nov 2012 16:37:33 +0100 [thread overview]
Message-ID: <20121120153733.GL5854@phenom.ffwll.local> (raw)
In-Reply-To: <20121115091448.7d1c5782@bwidawsk.net>
On Thu, Nov 15, 2012 at 09:14:48AM -0800, Ben Widawsky wrote:
> On Wed, 14 Nov 2012 11:06:42 -0800
> Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > On Wed, 14 Nov 2012 09:15:14 +0000
> > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > > The bspec was recently updated to remove the ability to update the
> > > semaphore using the MI_SEMAPHORE_BOX command, the ability to wait upon
> > > the semaphore value remained. Instead the advice is to update the
> > > register using the MI_LOAD_REGISTER_IMM command. In cursory testing,
> > > semaphores continue to function - the question is whether this fixes
> > > some of the deadlocks where the semaphore registers contained stale
> > > values?
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Daniel J Blueman <daniel@quora.org>
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> Tested-by: Ben Widawsky <ben@bwidawsk.net>
I seem to have forgotten to mention that this is merged. Bad, bad me ...
Thanks for the patch & review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-11-20 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 9:15 [PATCH] drm/i915: Use LRI to update the semaphore registers Chris Wilson
2012-11-14 19:06 ` Ben Widawsky
2012-11-15 17:14 ` Ben Widawsky
2012-11-20 15:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120153733.GL5854@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel@quora.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox