Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: don't prevent CPU idle states
@ 2012-12-08 12:48 Tomas Janousek
  2012-12-08 22:40 ` Daniel Vetter
  0 siblings, 1 reply; 2+ messages in thread
From: Tomas Janousek @ 2012-12-08 12:48 UTC (permalink / raw)
  To: intel-gfx; +Cc: Tomas Janousek

Commit 9ee32fea5f unconditionally prevents the CPU from entering idle states
until intel_dp_aux_ch completes for the first time, which never happens on my
DisplayPort-less intel gfx, causing the CPU to get rather hot.

Signed-off-by: Tomas Janousek <tomi@nomi.cz>
---
 drivers/gpu/drm/i915/i915_irq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 2e1d80d..914ecf4 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2732,7 +2732,7 @@ void intel_irq_init(struct drm_device *dev)
 	setup_timer(&dev_priv->hangcheck_timer, i915_hangcheck_elapsed,
 		    (unsigned long) dev);
 
-	pm_qos_add_request(&dev_priv->pm_qos, PM_QOS_CPU_DMA_LATENCY, 0);
+	pm_qos_add_request(&dev_priv->pm_qos, PM_QOS_CPU_DMA_LATENCY, PM_QOS_DEFAULT_VALUE);
 
 	dev->driver->get_vblank_counter = i915_get_vblank_counter;
 	dev->max_vblank_count = 0xffffff; /* only 24 bits of frame count */
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: don't prevent CPU idle states
  2012-12-08 12:48 [PATCH] drm/i915: don't prevent CPU idle states Tomas Janousek
@ 2012-12-08 22:40 ` Daniel Vetter
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2012-12-08 22:40 UTC (permalink / raw)
  To: Tomas Janousek; +Cc: intel-gfx

On Sat, Dec 08, 2012 at 01:48:13PM +0100, Tomas Janousek wrote:
> Commit 9ee32fea5f unconditionally prevents the CPU from entering idle states
> until intel_dp_aux_ch completes for the first time, which never happens on my
> DisplayPort-less intel gfx, causing the CPU to get rather hot.
> 
> Signed-off-by: Tomas Janousek <tomi@nomi.cz>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-08 22:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-08 12:48 [PATCH] drm/i915: don't prevent CPU idle states Tomas Janousek
2012-12-08 22:40 ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox