From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: clean up PIPECONF bpc #defines
Date: Mon, 17 Dec 2012 14:22:05 +0100 [thread overview]
Message-ID: <20121217132205.GN5737@phenom.ffwll.local> (raw)
In-Reply-To: <87k3shdjaw.fsf@intel.com>
On Mon, Dec 17, 2012 at 01:12:07PM +0200, Jani Nikula wrote:
> On Mon, 17 Dec 2012, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Ilk+ somehow used #defines in near the PIPESTAT definitions, which
> > decently confused me. Earlier platforms called it BPP instead of
> > BPC. Clean this all up.
>
> This patch does what it says on the box, so
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the review.
> *BUT* see a related comment below.
Discussed on irc, Haswell has now completely separate paths so comment
doesn't apply any longer.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-12-17 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 10:21 [PATCH] drm/i915: clean up PIPECONF bpc #defines Daniel Vetter
2012-12-17 11:12 ` Jani Nikula
2012-12-17 13:22 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217132205.GN5737@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox